[owncloud-devel] Changed path of vendor JS libraries

Bernhard Posselt dev at bernhard-posselt.com
Thu Dec 4 11:32:06 GMT 2014


I think the only thing an app should depend regarding javascript is 
jQuery. Everything else should be pulled in using bower in your own app.

On 12/04/2014 12:01 PM, Morris Jobke wrote:
> Today was a PR merged that also changed the path for jstz.js
>
> https://github.com/owncloud/core/pull/12522
>
> This is only needed on the login page to detect the users time zone. 
> If you use this maybe just ship it with your app, to avoid changes of 
> the paths in core.
>
> Morris
>
> Am 16.11.2014 um 10:40 schrieb Morris Jobke:
>> Hi devs,
>>
>> in the past week we moved all vendor/3rdparty JS libraries to a common
>> place. Previously they we mixed into the PHP vendor libraries in the
>> 3rdparty repo and the JS folder in core/js. Now they are all managed via
>> bower in core/vendor.
>>
>> If you include one of those in your apps and rely on the old path you
>> will get a blank page instead of the correct rendered app inside
>> ownCloud. So please check this.
>>
>> Following JS libraries (with their CSS files) have changed their path
>> and can cause a
>>
>> Fatal error: Uncaught exception 'Exception' with message 'js file not
>> found: script:NAME serverroot:/var/www/owncloud' in
>> /var/www/owncloud/lib/private/template/resourcelocator.php:46
>>
>> #11916 moment.js
>> #11936 jquery and jquery-migrate
>> #11982 underscore
>> #11985 snapjs (followup: #12158)
>>
>> #11970 handlebars
>> #11980 select2
>> #11981 jcrop
>> #11984 md5
>> #11989 zxcvbn
>> #12000 strengthify
>>
>> The first four libraries are include by default to every page. Therefore
>> you should just check for the six other. md5 is often included to be
>> used together with avatars and so the most possible candidate for 
>> breakage.
>>
>> Following libraries were dropped (because they were unneeded in core):
>>
>> #11953 listview.js
>> #11966 jquery.inview.js
>> #11968 jquery.placeholder.js
>> #11983 chosen.js
>> #12005 multiselect (was moved to user_ldap as it is only used there)
>>
>> We also introduce two new template shortcuts (pending documentation PR
>> can be found at https://github.com/owncloud/documentation/pull/636):
>>
>> vendor_script(APP, FILE)
>> vendor_style(APP, FILE)
>>
>> They both result in path/to/apps/APP/vendor/FILE.js (or .css). If APP is
>> omitted they will be looked up in owncloud/core/vendor/FILE.js. The core
>> PR for these functions is #11916 and is already merged into master.
>>
>> Thanks and happy coding!
>>
>> Morris
>> _______________________________________________
>> Devel mailing list
>> Devel at owncloud.org
>> http://mailman.owncloud.org/mailman/listinfo/devel
> _______________________________________________
> Devel mailing list
> Devel at owncloud.org
> http://mailman.owncloud.org/mailman/listinfo/devel



More information about the Devel mailing list